Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Export BT util test files #3372

Merged
merged 7 commits into from
Jan 18, 2023
Merged

Export BT util test files #3372

merged 7 commits into from
Jan 18, 2023

Conversation

jwallace42
Copy link
Contributor

Basic Info

Info Please fill out this column
Ticket(s) this addresses NONE
Primary OS tested on Ubuntu
Robotic platform tested on N/A

Description of contribution in a few bullet points

In order to have users write tests for bt nodes in order modules, the test utility files must be exported.

Description of documentation updates required from your changes

Future work that may be required in bullet points

For Maintainers:

  • Check that any new parameters added are updated in navigation.ros.org
  • Check that any significant change is added to the migration guide
  • Check that any new features OR changes to existing behaviors are reflected in the tuning guide
  • Check that any new functions have Doxygen added
  • Check that any new features have test coverage
  • Check that any new plugins is added to the plugins page
  • If BT Node, Additionally: add to BT's XML index of nodes for groot, BT package's readme table, and BT library lists

@mergify
Copy link
Contributor

mergify bot commented Jan 17, 2023

@jwallace42, please properly fill in PR template in the future. @SteveMacenski, use this instead.

  • Check that any new parameters added are updated in navigation.ros.org
  • Check that any significant change is added to the migration guide
  • Check that any new features OR changes to existing behaviors are reflected in the tuning guide
  • Check that any new functions have Doxygen added
  • Check that any new features have test coverage
  • Check that any new plugins is added to the plugins page
  • If BT Node, Additionally: add to BT's XML index of nodes for groot, BT package's readme table, and BT library lists

@jwallace42 jwallace42 changed the title export test files Export BT util test files Jan 17, 2023
SteveMacenski
SteveMacenski requested changes Jan 17, 2023
View reviewed changes
nav2_behavior_tree/CMakeLists.txt Outdated Show resolved Hide resolved
@SteveMacenski
Copy link
Member

SteveMacenski commented Jan 18, 2023 •
edited
Loading

Woof. Lots of linting issues this created. You need to update the header guards for 10 files from moving them around

@SteveMacenski SteveMacenski merged commit 3ac05f4 into ros-navigation:main Jan 18, 2023
andrewlycas pushed a commit to StratomInc/navigation2 that referenced this pull request Feb 23, 2023
@jwallace42
Export BT util test files (ros-navigation#3372)
097e891 
* export test files

* removed space

* move order

* file header refactor

* space

* code review

* lint fix
@aosmw aosmw mentioned this pull request Aug 30, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SteveMacenski SteveMacenski SteveMacenski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jwallace42 @SteveMacenski